Clojure Review

What it does

This skill analyzes Clojure code to ensure adherence to Metabase's internal style guide and, optionally, a community-provided style guide (if CLOJURE_STYLE_GUIDE.adoc exists in the working directory). It flags violations of these guidelines and suggests improvements. The tool focuses on identifying issues; it avoids providing positive feedback or confirming correctness.

When to use it

• Reviewing pull requests containing Clojure code changes.
• Ensuring new Clojure code aligns with Metabase's coding standards.
• Identifying potential style and organizational issues in existing Clojure codebases.
• Automating parts of the code review process.

Key capabilities

• Checks compliance with the Metabase Clojure style guide.
• Optionally checks against a community Clojure style guide (CLOJURE_STYLE_GUIDE.adoc).
• Validates naming conventions (kebab-case, function endings).
• Verifies documentation standards (Markdown formatting, TODO comments with author and date).
• Enforces code organization rules (private variables, line length limits).
• Checks test structure and naming.
• Ensures correct module patterns are used.
• Validates REST API conventions (response schemas, route names).
• Verifies MBQL usage guidelines.
• Confirms database model and table naming conventions.

Example prompts

• "Review this Clojure code for style violations."
• "Check this pull request against the Metabase Clojure style guide."
• "Analyze this file for adherence to coding best practices."

Tips & gotchas

• The skill will not flag missing parentheses, as these are handled by a separate linter.
• Ensure CLOJURE_STYLE_GUIDE.adoc is present in the working directory if you want it to check against the community style guide.
• Focus on addressing the flagged issues; avoid trivial comments or confirmations of correctness.