Combine Code Review

What it does

This skill, Combine Code Review, automatically synthesizes feedback from multiple code reviews into a prioritized and actionable list for developers. It leverages reference materials related to reactive programming in Swift (specifically using Combine) to identify potential issues and best practices. The tool helps ensure adherence to established coding guidelines by highlighting areas needing attention based on provided checklists and review questions.

When to use it

• When reviewing code that utilizes the Combine framework for reactive programming.
• To quickly identify common pitfalls related to memory management, error handling, or operator usage in Combine code.
• As a supplementary tool during code reviews to ensure consistency with established coding standards and best practices.

Key capabilities

• Reference Material Integration: Provides links to documentation on various Combine concepts including:
  • Operators (e.g., flatMap, combineLatest)
  • Memory Management (AnyCancellable, retain cycles)
  • Error Handling (tryMap, catch)
• Review Checklist: Offers a checklist of common issues to look for, such as ensuring proper use of weak self and avoiding assign(to:on:self).
• Review Questions: Presents key questions to guide code reviewers in identifying potential problems (e.g., subscription retention, error handling behavior).

Example prompts

• "Analyze this Combine code snippet for memory management issues."
• "Check this operator chain for correct flatMap usage."
• "Review this code and highlight any potential retain cycles."

Tips & gotchas

• This skill is specifically designed for code using the Combine framework in Swift. It will not be effective for other programming languages or paradigms.
• The provided reference materials are intended to supplement, not replace, a thorough understanding of Combine concepts.